Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corpse light and line addition #191

Merged
merged 2 commits into from
Nov 15, 2020
Merged

Corpse light and line addition #191

merged 2 commits into from
Nov 15, 2020

Conversation

bbassie
Copy link
Contributor

@bbassie bbassie commented Nov 8, 2020

image

Cooldude2606
Cooldude2606 requested changes Nov 11, 2020
View reviewed changes
Copy link
Member

@Cooldude2606 Cooldude2606 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature, a way to hide all tracers would be nice but is not required.
There are two optimizations which should be made.

modules/addons/death-logger.lua Outdated Show resolved Hide resolved
modules/addons/death-logger.lua Show resolved Hide resolved
@bbassie
Draw corpse lines improvement
8defd39 
* Itterate over deaths in reverse.
* Check expired bodies and break out of the loop.
@bbassie bbassie closed this Nov 15, 2020
@bbassie bbassie reopened this Nov 15, 2020
@bbassie bbassie requested a review from Cooldude2606 November 15, 2020 18:43
Cooldude2606
Cooldude2606 approved these changes Nov 15, 2020
View reviewed changes
Copy link
Member

@Cooldude2606 Cooldude2606 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good and requested changes have been implemented.

@Cooldude2606 Cooldude2606 merged commit 35f3ffe into explosivegaming:dev Nov 15, 2020
@bbassie bbassie deleted the feature/corpse-finder branch November 24, 2020 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cooldude2606 Cooldude2606 Cooldude2606 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbassie @Cooldude2606